Use exporter-toolkit #71
Merged
+122
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evedel
reviewed
Mar 26, 2023
main.go
Outdated
Comment on lines
22
to
23
| addr = flag.String("metrics-address", ":2112", "The address to listen on for HTTP requests.") | ||
| tlsConf = flag.String("metrics-tls-config", "", "The TLS config file for your metrics.") |
There was a problem hiding this comment.
Nice addition 👍 would it be better to have a config section for metrics instead? (have to duplicate addr for backward compatibility atm) so the arg key section is not growing.
metrics:
- servePort: 2112
- namePrefix: bla
- tlsConfigFile: /path
|
Why do we need a landing page? |
You do have one already: https://github.com/resmoio/kubernetes-event-exporter/blob/master/pkg/metrics/metrics.go#L26 This is just replacing the custom html with something that exporter-toolkit provides (it's not a super interesting feature, the TLS support is more interesting) |
This adds support for TLS configuration on the http metrics endpoint as well as support for a landing page.
mustafaakin
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for TLS configuration on the http metrics endpoint as well as support for a landing page.