Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart enchantments #97

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Chart enchantments #97

merged 2 commits into from
Jul 21, 2023

Conversation

jkroepke
Copy link

  • Add ServiceMonitor
  • Allow namespaced RBAC (works in combination with namespace on config)
  • Allow to configure customized RBAC rules (fixes ClusterRole rules are too permissive #75)
  • Ensure that chart labels are defined on each object
  • Ensure that kubernetes-event-exporter is restarted, if the config has been changes (https://helm.sh/docs/howto/charts_tips_and_tricks/#automatically-roll-deployments)
  • Set kubernetes hardening by default
  • Allow to define imagePullSecrets and image.registry form Values.global
  • Add topologySpreadConstraints property
  • Add extraVolumes and extraVolumeMounts (useful for manual AWS IRSA setup)
  • Add deploymentAnnotations, deploymentLabels and podLabels (useful or reloader)
  • Set namespaceOverride to empty by default.

@jkroepke
Copy link
Author

@mustafaakin I would appreciate a review here, since you do #54

@jacobredesign
Copy link

This looks great @jkroepke , was looking for this functionality regarding namespaces as our kube hosting provider doesn't give us cluster level api access so things like clusterroles are a non-starter.

@jkroepke
Copy link
Author

@jacobredesign great that it l ooks good ob your side, too. 👍

@resmoio what did you think?

@jkroepke
Copy link
Author

@mustafaakin should I split this PR into smaller pieces?

@miai10
Copy link

miai10 commented Jul 11, 2023

Does this MR fix this bug: #106 ?

@jkroepke
Copy link
Author

@miai10 The issues was recently introduced but this MR would also fix the issue you mentioned.

@jkroepke
Copy link
Author

@jacobredesign @resmoio @mustafaakin I would appreciate a review here.

@mustafaakin mustafaakin merged commit 9ee0ba0 into resmoio:master Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClusterRole rules are too permissive
4 participants