Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for basic auth #118

Merged
merged 4 commits into from
May 22, 2024
Merged

Add support for basic auth #118

merged 4 commits into from
May 22, 2024

Conversation

dfarr
Copy link
Member

@dfarr dfarr commented May 22, 2024

Additionally consolidates store options into a single type.

Additionally consolidates store options into a single type.
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2024

Codecov Report

Attention: Patch coverage is 89.69072% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 83.06%. Comparing base (19549fd) to head (9e6780d).

Files Patch % Lines
lib/core/stores/remote.ts 88.00% 9 Missing ⚠️
lib/resonate.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   81.23%   83.06%   +1.83%     
==========================================
  Files          22       23       +1     
  Lines        1332     1358      +26     
  Branches      361      335      -26     
==========================================
+ Hits         1082     1128      +46     
+ Misses        250      230      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dfarr dfarr merged commit 6ed1588 into main May 22, 2024
2 checks passed
@dfarr dfarr deleted the feature/basic-auth branch May 22, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants