Removes "default" options from the invocation #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default options in the invocation were in reality the registered options from the top level function call. This commit changes the code to express that more clearly and removes the split functions that were a source of confusion.
|
In this change I also included a few smaller changes that I think make the code a bit more clear like naming the |
avillega
commented
Jun 21, 2024
| @@ -210,22 +210,36 @@ export class Context { | |||
| // the id is either: | |||
| // 1. a provided string in the case of a deferred execution | |||
| // 2. a generated string in the case of an ordinary execution | |||
| const id = typeof func === "string" ? func : `${parent.id}.${parent.counter}`; | |||
| const id = typeof func === "string" ? func : `${parent.id}.${parent.counter}.${func.name}`; | |||
There was a problem hiding this comment.
This is probably the controvertial change in this PR. I added the name of the function to the id. My idea is to have more insight into the distributed call graph, once we get to observability.
There was a problem hiding this comment.
Looks good! I like that it's informational only, we don't rely on the name of the function to ensure uniqueness
dfarr
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default options in the invocation were in reality
the registered options from the top level function call. This commit changes the code to express that more clearly and removes the split functions that were a source of confusion.