Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made by calamity lime List of Changes: #59

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexderpyfox
Copy link

@alexderpyfox alexderpyfox commented Apr 29, 2024

You can save items with the same name into the same folder. Item thumbnails are saved to a dedicated folder since I like to clear the cache that Resonite dumps in the AppData\LocalLow folder. Folder names have invalid characters removed from them automatically, this is reflected in Resonite. Resonite allowed file/folder names with characters that Windows does not allow in paths. The Local Storage button is now brick red, I just like it but maybe I'll change it just to keep you on your toes, who knows.

  • The mod id matches the harmony id if used by the mod and starts with the same id as your author folder
  • All used links are valid
  • Your ResoniteMod.Version must match the version being added in the manifest
  • Your AssemblyVersion should match the mod version
  • You have included an accurate sha256 hash for each artifact
  • Do not remove old mods. Instead, use the deprecated flag
  • Follow the Resonite Policies and Guidelines and Mod Submission Guidelines

You can save items with the same name into the same folder.
Item thumbnails are saved to a dedicated folder since I like to clear the cache that Resonite dumps in the AppData\LocalLow folder.
Folder names have invalid characters removed from them automatically, this is reflected in Resonite. Resonite allowed file/folder names with characters that Windows does not allow in paths.
The Local Storage button is now brick red, I just like it but maybe I'll change it just to keep you on your toes, who knows.
@XDelta XDelta added the Community PR Manifest additon made for somone else's mod(s) label Apr 29, 2024
"category": "Technical Tweaks",
"sourceLocation": "https://github.com/LimeProgramming/LocalStorage",
"versions": {
"1.0.0": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't match the version linked 2.0.3

@@ -0,0 +1,16 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be under 'me.CalamityLime' for the author folder as they are the author. Also create an author.json for them. If you haven't written the mod you are submitting or being listed as an additional author, you don't need to have your own folder/author.json

The Folder name is still ExampleMod, this should be changed to LocalStorage

@@ -0,0 +1,16 @@
{
"name": "LocalStorageV2 (Lime fork)",
"id": "me.CalamityLime.LocalStorage",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably include 'LocalStorageV2' in the id or change the name to be 'LocalStorage'

"sourceLocation": "https://github.com/LimeProgramming/LocalStorage",
"versions": {
"1.0.0": {
"releaseUrl": "https://github.com/LimeProgramming/LocalStorage/tag/2.0.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

404, looks like it should be https://github.com/LimeProgramming/LocalStorage/releases/tag/2.0.3

@XDelta XDelta added the Awaiting response Waiting for a response from author label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting response Waiting for a response from author Community PR Manifest additon made for somone else's mod(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants