Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Initial Corrections File for DD 2.0 Testing #135

Closed
darnjo opened this issue Sep 21, 2022 · 0 comments
Closed

Create Initial Corrections File for DD 2.0 Testing #135

darnjo opened this issue Sep 21, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request high priority

Comments

@darnjo
Copy link
Member

darnjo commented Sep 21, 2022

In addition to using automated matching techniques for field and lookup mapping, we will also be using manual mappings collected from the Industry Aggregates service to suggest the correct value when we find alternate ones.

The corrections file can include both fields and lookups, but the attached item only includes lookups at the moment.

  • Field corrections will be suggested at the top level.
  • Fields that have lookups will have corrections in a nested lookups object with each of the suggestions contained within.

There's also a possibility that some values only apply for some property classes, such as RESI. In that case, the item should include a propertyClasses array with those items included.

Another case is that a given item might also have a related field and value that goes along with it, in which case there's a relatedFields object nested within that item.

See "Commercial Land" in the mapping file for an example of both of the above cases.

If a given item looks incorrect but does not have any suggested mappings, or if we don't know the mappings at this point and want to come back to it later, an empty array may be added to flag the item but not provide any values. See "Vacant Commercial Lot" for an example of this.

The mappings file for the branch related to this issue is contained here and should be committed back to the branch with each batch of changes: https://github.com/RESOStandards/web-api-commander/blob/135-create-initial-corrections-file-for-dd-20-testing/src/main/resources/disallowed-values-dd-2.0.json

This file will be used by the Commander for DD 2.0 certification, and we'll also make a service out of it so people can look up the correct mappings if they want.

@darnjo darnjo added enhancement New feature or request high priority labels Sep 21, 2022
@darnjo darnjo added this to the Data Dictionary 2.0 milestone Sep 21, 2022
@darnjo darnjo added this to Backlog in RESO Endorsement Testing Tools via automation Sep 21, 2022
@darnjo darnjo pinned this issue Sep 21, 2022
@darnjo darnjo moved this from Backlog to In progress in RESO Endorsement Testing Tools Sep 21, 2022
@darnjo darnjo closed this as completed Oct 21, 2023
RESO Endorsement Testing Tools automation moved this from In progress to Done Oct 21, 2023
@darnjo darnjo unpinned this issue Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high priority
Development

No branches or pull requests

2 participants