Add pytest to deps and CI #156
Conversation
pyproject.toml
Outdated
| @@ -14,7 +14,7 @@ description = "Hydrological Simulation Program - Python" | |||
| dependencies = [ | |||
| "cltoolbox", | |||
| "numba", | |||
| "pandas", | |||
| "pandas>=1.5,<2", | |||
There was a problem hiding this comment.
we should refactor all calls to df.append() since it's deprecated. use pandas.concat([df1, df2]) going forward
There was a problem hiding this comment.
I did change one df.append() that errored out in my testing in #159.
Why those limits for pandas?
There was a problem hiding this comment.
Because append went from warning to error with V2 and I wanted to punt the refactor. Sounds like we probably caught the same one that is in the test line-of-fire, but there may be many more lurking…
| @@ -46,6 +46,11 @@ keywords = [ | |||
| license = {file = "LICENSE"} | |||
| requires-python = ">=3.10" | |||
|
|
|||
| [project.optional-dependencies] | |||
| slim = ["numba", "pandas"] | |||
There was a problem hiding this comment.
most of this library doesn't depend on the cli, so there can be a slim option. In fact, a better approach would be to move the dependency on cltoolbox to an optional dependency tag called cli = ["cltoolbox"].
There was a problem hiding this comment.
My vote is to keep cltoolbox part of the default dependencies. The CLI is the only way I have run HSP2. A CLI is much easier to use on a cluster or within a parameter estimation run where typically you build out shell scripts or batch files.
There was a problem hiding this comment.
Ok, I don’t mean to propose we remove a cli option. When I use hsp2 on a cluster I use it as a library as part of another program I’ve written that has its own cli. I guess the question here is if you should have to type pip install hsp2[cli] or if I should have to type pip install hsp2[slim]. I don’t truly care either way, as long as there is a slim line available.
Of course we could erase the need for this whole conversation by rewriting the 2 command cli in argparse which I suggest (and volunteer!) to do.
…inning to allow test; TODO: refactor readUCI for pandas>=2
…aths at the end of gitignore
…nyones long-running hspf job
…ch room for improvement
|
@PaulDudaRESPEC please review. This PR brings test coverage for all code in the project up to 70%. The failing last cli test looks like an additional packaging detail regarding the data files, but tests pass! |
|
@PaulDudaRESPEC also, as of this PR you have the option to adopt a policy of having all PRs be required to pass the test suite (which will grow and change) in order for you to approve and merge. Your review will have to include a check to ensure the PR didn’t somehow make the test easier, haha. should you adopt such a policy, and I think you should, let’s begin with this PR and hold it until I fix the data package bug. I think I know the fix. |
austinorr
force-pushed
the
pytest
branch
2 times, most recently
from
ce4e237
to
10fcb7a
Compare
|
@PaulDudaRESPEC This PR completes the following:
|
This PR adds
pytestto the optional project dependencies, and should get automated tests passing in CI (partially, there's another PR coming that fixes the packaging/install so that the cli works again).