-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cycling between two hashes leads to incorrect location stack #48
Comments
Cycling between three actions is fine - the bug only occurs when transitioning to the previous hash. |
Reproduceable on the |
hedgepigdaniel
added a commit
that referenced
this issue
Sep 10, 2019
…next action (#56) Previously, actions dispatched by the user to push/replace the route were intercepted and turned into back/next actions if they matched the next or previous entry in the history stack. This meant that it was not possible to push/replace the next/previous route in the history stack. This change removes that behaviour, so that the direction of dispatched actions are preserved. BREAKING CHANGE: dispatching a route that matches the previous/next route in the history stack is no longer reinterpreted as a back/next action BREAKING CHANGE: history functions `set`/`setParams`/`setState`/`setQuery`/`setHash`/`setBasename` no longer accept a function as an argument BREAKING CHANGE: history functions `set`/`setParams`/`setState`/`setQuery` no longer merge their arguments with the existing params/state/query BREAKING CHANGE: history functions `back`/`next`/`jump` no longer accept a state argument Fixes #48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If you render links corresponding to these actions and then click on them in the following order:
Then the
kind
of the 3rd action when it hits the reducers isback
rather thanpush
, and the browser stack has 2 entries instead of three.The text was updated successfully, but these errors were encountered: