Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: fix CI #16

Merged
merged 5 commits into from Jan 20, 2019
Merged

Chore: fix CI #16

merged 5 commits into from Jan 20, 2019

Conversation

hedgepigdaniel
Copy link
Collaborator

@hedgepigdaniel hedgepigdaniel commented Jan 18, 2019

  • Run prettier on all files, (the updated README files were not prettified)
  • Add an exception for an eslint rule which is not applicable to the example code
  • Make sure that the rudy-src-main entry point is used by the boilerplate for all libraries in the repo, even for production builds
  • Correct the value of rudy-src-main on some libraries
  • Correct build script on libraries so that they do actually get built before the integration tests run

@hedgepigdaniel
Copy link
Collaborator Author

Not sure why the CI is failing, yarn run check works fine for me locally. I'll need to investigate.

@ScriptedAlchemy
Copy link
Member

I’ll move the keys into Travis. On my phone but will review it more thoroughly when I get home. Thanks for your work here. Great seeing a green check mark

.travis.yml Outdated Show resolved Hide resolved
Copy link
Member

@ScriptedAlchemy ScriptedAlchemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, merge when ready

@hedgepigdaniel hedgepigdaniel merged commit bf5d40b into master Jan 20, 2019
@hedgepigdaniel hedgepigdaniel deleted the bug/ci branch April 15, 2019 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants