Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client Side routing support #116

Closed
wrick17 opened this issue May 25, 2020 · 5 comments · Fixed by #206
Closed

Client Side routing support #116

wrick17 opened this issue May 25, 2020 · 5 comments · Fixed by #206
Assignees
@esprush
Labels
enhancement New feature or request
Projects
App Roadmap
Milestone
v0.4.0

Comments

@wrick17
Copy link

wrick17 commented May 25, 2020

When doing client side navigation, the whole page refreshes for all the devices.

Am I missing anything? Any way to get around this?
@duongleh
Copy link

I got the same problem.

@manojVivek
Copy link
Collaborator

The current URL syncing logic considers this as a URL change and sends it to all other devices to load it.
We will have to think of a way to sync the URLs while supporting client side routing.

@manojVivek manojVivek added the enhancement New feature or request label May 25, 2020
@duongleh
Copy link

duongleh commented May 25, 2020 •
edited
Loading

@manojVivek You can have a button to disable syncing URL. Whoever works with client routing app can manually trigger this mode, and the browser will do the routing for you. This can be a temporary solution until you find an optinal one.

@manojVivek manojVivek modified the milestones: v0.1.6, v0.1.7 May 28, 2020
@manojVivek manojVivek modified the milestones: v0.1.7, v.0.1.8 Jun 10, 2020
@pratyushok
Copy link

We see a 0.2.0. Can we move the milestone on this?

@manojVivek
Copy link
Collaborator

@pratyushok Thank you for pointing it out, it is changed now.

@manojVivek manojVivek added this to In progress in App Roadmap Jun 13, 2020
@manojVivek manojVivek modified the milestones: v.0.3.0, v0.4.0 Jun 17, 2020
@esprush esprush linked a pull request Jun 19, 2020 that will close this issue
Feature/sync urls #206
Merged
@manojVivek manojVivek moved this from In progress to Ready for Release in App Roadmap Jun 24, 2020
@esprush esprush moved this from Ready for Release to Release 0.4.0 in App Roadmap Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@esprush esprush

Labels
enhancement New feature or request
Projects
No open projects
App Roadmap
  
Release 0.4.0
Milestone
v0.4.0
Development

Successfully merging a pull request may close this issue.

Feature/sync urls responsively-org/responsively-app
5 participants
@manojVivek @wrick17 @esprush @duongleh @pratyushok