Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Scroll sync does not work when dragging the scrollbar #193

Closed
Kidcredo opened this issue Jun 16, 2020 · 5 comments
Closed

馃悰 Scroll sync does not work when dragging the scrollbar #193

Kidcredo opened this issue Jun 16, 2020 · 5 comments
Labels
bug Something isn't working
Projects
App Roadmap
Milestone
v0.4.0

Comments

@Kidcredo
Copy link
Contributor

I am using Responsively 0.2.0 on a Windows 10 and when I scroll using the scrollbar within the device the scroll sync function does not seem to be working.
ky7XpmvqG1
@manojVivek manojVivek added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Jun 16, 2020
@manojVivek manojVivek added this to Accepted in App Roadmap Jun 16, 2020
@jonathanurias96
Copy link

jonathanurias96 commented Jun 16, 2020 •
edited
Loading

I would like to work on this issue. Can you tell me a little bit more about what it does and what it is supposed to do?

@manojVivek
Copy link
Collaborator

@jonathanurias96 You need to figure out why the scrollbar drag is not generating the scroll event and how it is different from the normal scroll that it got missed from the sync events.

@jonathanurias96
Copy link

Got it! I will work on it.

@jonathanurias96
Copy link

jonathanurias96 commented Jun 22, 2020 •
edited
Loading

Hello @manojVivek I believe this PR can fix the issue #216.
Please review.

@jonathanurias96 jonathanurias96 mentioned this issue Jun 23, 2020
Merged
@manojVivek manojVivek moved this from Accepted to In PR in App Roadmap Jun 23, 2020
@manojVivek manojVivek added this to the v0.4.0 milestone Jun 23, 2020
@manojVivek
Copy link
Collaborator

This will go live in the v0.4.0 release.

@manojVivek manojVivek moved this from In PR to Ready for Release in App Roadmap Jun 23, 2020
@esprush esprush moved this from Ready for Release to Release 0.4.0 in App Roadmap Jun 27, 2020
@manojVivek manojVivek removed good first issue Good for newcomers help wanted Extra attention is needed labels Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
App Roadmap
  
Release 0.4.0
Milestone
v0.4.0
Development

No branches or pull requests
3 participants
@manojVivek @Kidcredo @jonathanurias96