Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollbars do not appear consistent with the UI #194

Closed
Kidcredo opened this issue Jun 16, 2020 · 4 comments · Fixed by #195
Closed

Scrollbars do not appear consistent with the UI #194

Kidcredo opened this issue Jun 16, 2020 · 4 comments · Fixed by #195
Assignees
Labels
bug Something isn't working
Projects
Milestone

Comments

@Kidcredo
Copy link
Contributor

Kidcredo commented Jun 16, 2020

The scrollbar on Windows doesn't appear consistent with the overall user interface of the app.
image

I am already working on a fix for this but i am unable to target the scrollbar within the device containers which are in a WebView which I am unable to fix at the moment.

@manojVivek manojVivek added this to In PR in App Roadmap Jun 17, 2020
@manojVivek manojVivek added the bug Something isn't working label Jun 17, 2020
@manojVivek manojVivek linked a pull request Jun 17, 2020 that will close this issue
@manojVivek manojVivek added this to the v0.4.0 milestone Jun 17, 2020
@Kidcredo
Copy link
Contributor Author

Just need to figure out how to load the same CSS that was merged recently to load every time the WebView for device containers is updated.

@manojVivek
Copy link
Collaborator

@Kidcredo I don't think we have to do that since that will interfere with the page's styles and might break something.

@Kidcredo
Copy link
Contributor Author

Kidcredo commented Jun 23, 2020

Anyways i was unable to find a way to inject css in the webview.

@manojVivek
Copy link
Collaborator

@Kidcredo CSS can be injected into webview using the insertCss api. Ref: https://www.electronjs.org/docs/api/web-contents#contentsinsertcsscss-options

But anyway, I'm closing this issue as we are good with it now. Thanks again for the work on this. 🙌

@manojVivek manojVivek moved this from In PR to Ready for Release in App Roadmap Jun 23, 2020
@esprush esprush moved this from Ready for Release to Release 0.4.0 in App Roadmap Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
App Roadmap
  
Release 0.4.0
Development

Successfully merging a pull request may close this issue.

2 participants