Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive Mode dimensions are in the wrong order #295

Closed
SteveDesmond-ca opened this issue Jul 8, 2020 · 4 comments · Fixed by #304
Closed

Responsive Mode dimensions are in the wrong order #295

SteveDesmond-ca opened this issue Jul 8, 2020 · 4 comments · Fixed by #304
Assignees
Labels
bug Something isn't working
Projects
Milestone

Comments

@SteveDesmond-ca
Copy link

Steps to reproduce:

  • launch Responsively v0.6.1
  • resize "Responsive Mode" to 800px wide by 600px tall

Expected result:

  • dimensions show as "800x600"

Observed result:

  • dimensions show as "600x800"

image

@jjavierdguezas
Copy link
Contributor

jjavierdguezas commented Jul 8, 2020

The issue here is with the Tilt Device button which is not working with this special device
In the image shared by @SteveDesmond-ca it can be seen that the button was pressed, so the dimension shows HxW instead of WxH
When the button is not pressed the info displayed is valid
When the button is pressed the info flips but not the view, it also seems that this action is not allowed for this device (the button looks gray as if it was disabled) but the click does something

resp2

cc: @manojVivek

@SteveDesmond-ca
Copy link
Author

Thanks for the clarification, indeed the "half-working but appearing disabled" icon was not obvious!

@manojVivek
Copy link
Collaborator

Even the re-sizable device should be allowed for rotation, I guess.

@kvnam Thoughts?

@kvnam
Copy link
Contributor

kvnam commented Jul 9, 2020

@manojVivek @jjavierdguezas I agree, the rotation should work for this mode as well. Will get this in with the other fixes as well. Thanks guys!

@manojVivek manojVivek added the bug Something isn't working label Jul 12, 2020
@manojVivek manojVivek added this to New in App Roadmap via automation Jul 12, 2020
@manojVivek manojVivek added this to the v.0.7.0 milestone Jul 12, 2020
@manojVivek manojVivek moved this from New to Ready for Release in App Roadmap Jul 12, 2020
@manojVivek manojVivek moved this from Ready for Release to Release v0.7.0 in App Roadmap Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
App Roadmap
  
Release v0.7.0
4 participants