-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add device emulation params for Mobile devices #31
Comments
Apparently webview does not support device emulation electron/electron#5488. |
@romanakash I guess, it is possible by sending an Can you please check this out - https://github.com/AglaiaWang/electron-quick-start/blob/master/main.js#L51 ? |
I tried that out but there is a currently unresolved issue with electron which sets the parent browser window to touch mode as well. electron/electron#18438 |
@romanakash Ah, enabling it for the whole app would make it look terrible. But I have an idea to work around this bug, let me know what do you think about the following:
So this way, we will achieve what the user wants. @romanakash Please let me know your thoughts. |
Ok, that sounds good. I'll work on it |
Great, @romanakash you can use this |
Okay, I ran into some issues with this. I was able to enable the touch circle on mouse enter but the mouse leave listener doesn't fire anymore after the cursor has changed into a touch circle. So there wasn't any way of disabling the touch circle without explicitly pressing the toggle button again. This lead to some confusion from a ux perspective as toggling the touch circle on one web view is just going to toggle the touch circle for the whole app. So I decided to move the toggle button to the scroll buttons container as shown here. |
Add the emulation parameters correctly for the devices with
touchscreen
capability to support touch events liketap
,swipe
etc. Right now only mouse events are supported by all devices.The text was updated successfully, but these errors were encountered: