Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zoom controls are hidden below devices tab in individual device mode #313

Closed
sebastianlp opened this issue Jul 15, 2020 · 4 comments · Fixed by #323
Closed

Zoom controls are hidden below devices tab in individual device mode #313

sebastianlp opened this issue Jul 15, 2020 · 4 comments · Fixed by #323
Assignees
@sebastianlp
Labels
bug Something isn't working
Projects
App Roadmap
Milestone
v0.8.0

Comments

@sebastianlp
Copy link

When you are working with a setup like the image below (using a screen spliced by 2/3 and 1/3) and working with some devices to make the tab appears, you open the Zoom input, the submenu opens below the devices tab

Using this setup:
Version: 0.6.1
Electron: 8.3.0
Chrome: 80.0.3987.165
Node.js: 12.13.0
V8: 8.0.426.27-electron.0
OS: Darwin x64 19.4.0

Image
image
@sebastianlp sebastianlp changed the title Devices tabs Zoom controls Zoom controls below devices tab Jul 15, 2020
@manojVivek
Copy link
Collaborator

@sebastianlp This is a terrible bug, thanks for reporting it. 👍

@manojVivek manojVivek added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Jul 15, 2020
@manojVivek manojVivek added this to New in App Roadmap via automation Jul 15, 2020
@manojVivek manojVivek moved this from New to Higher-Priority Items in App Roadmap Jul 15, 2020
@manojVivek manojVivek changed the title Zoom controls below devices tab Zoom controls are hidden below devices tab in individual device mode Jul 15, 2020
@pajaydev
Copy link
Contributor

@manojVivek Shall I take this one ?.

@manojVivek
Copy link
Collaborator

@pajaydev That would be awesome. Assigning it to you. 👍

@manojVivek manojVivek removed good first issue Good for newcomers help wanted Extra attention is needed labels Jul 15, 2020
@manojVivek manojVivek moved this from Higher-Priority Items to In progress in App Roadmap Jul 15, 2020
@manojVivek manojVivek reopened this Jul 15, 2020
@manojVivek manojVivek reopened this Jul 15, 2020
@sebasrodriguez sebasrodriguez mentioned this issue Jul 16, 2020
Merged
@manojVivek
Copy link
Collaborator

@pajaydev @sebastianlp's PR is fixing it, you haven't looked into it.
Closing this issue with it.

@manojVivek manojVivek assigned sebastianlp and unassigned pajaydev Jul 18, 2020
@manojVivek manojVivek added this to the v0.8.0 milestone Jul 18, 2020
@manojVivek manojVivek moved this from In progress to Ready for Release in App Roadmap Jul 18, 2020
@manojVivek manojVivek moved this from Ready for Release to Release v0.8.0 in App Roadmap Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastianlp sebastianlp

Labels
bug Something isn't working
Projects
No open projects
App Roadmap
  
Release v0.8.0
Milestone
v0.8.0
Development

Successfully merging a pull request may close this issue.

fix: Solves zoom toolbar being hidden behind the devices tabs omboo/responsively-app
3 participants
@manojVivek @sebastianlp @pajaydev