Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist scroll position across page reloads #328

Closed
marcoscannabrava opened this issue Jul 18, 2020 · 11 comments
Closed

Persist scroll position across page reloads #328

marcoscannabrava opened this issue Jul 18, 2020 · 11 comments
Assignees
Labels
enhancement New feature or request
Projects
Milestone

Comments

@marcoscannabrava
Copy link

Everytime you save a file the screen refreshes and scrolls to the top.

  • e.g. Building a footer component on responsively becomes pretty annoying as the page scrolls back to the top everytime I save.
@manojVivek
Copy link
Collaborator

@marcoscannabrava You are suggesting the scroll position should be restored to the same after the reload?

@manojVivek manojVivek added the more info needed Need more details about the issue label Jul 19, 2020
@marcoscannabrava
Copy link
Author

Exactly. If you picture someone building a footer on a homepage you'll understand what I went through yesterday. Everytime I made a change I had to go to the Responsively.app tab and scroll back down to the footer. I think it's super important, honestly.
Congratulations for the app. It's a game changer.

@manojVivek manojVivek changed the title The Window Position Won't Persist On Refresh Persist scroll position across page reloads Jul 20, 2020
@manojVivek manojVivek added enhancement New feature or request help wanted Extra attention is needed and removed more info needed Need more details about the issue labels Jul 20, 2020
@manojVivek manojVivek added this to New in App Roadmap via automation Jul 20, 2020
@manojVivek manojVivek moved this from New to Accepted in App Roadmap Jul 20, 2020
@naher94
Copy link

naher94 commented Jul 24, 2020

Ditto on this one!

@ewazlak
Copy link

ewazlak commented Jul 24, 2020

Upvote!

@manojVivek manojVivek moved this from Accepted to Higher-Priority Items in App Roadmap Jul 25, 2020
@rafaykhawar09
Copy link

Cool

@jjavierdguezas
Copy link
Contributor

hi @manojVivek maybe I can give this a try

@manojVivek
Copy link
Collaborator

That is great, thanks @jjavierdguezas. 🙌

This might help: https://www.npmjs.com/package/electron-retain-webview-scroll

@manojVivek manojVivek moved this from Higher-Priority Items to In progress in App Roadmap Jul 25, 2020
@manojVivek manojVivek removed the help wanted Extra attention is needed label Jul 25, 2020
@esprush
Copy link
Member

esprush commented Aug 3, 2020

@jjavierdguezas @manojVivek came across below option in browserSync. looks like they support this out of the box.
https://www.browsersync.io/docs/options#option-scrollRestoreTechnique

@manojVivek
Copy link
Collaborator

@esprush I think, this only applies when browser-sync is doing the reloading.

@esprush
Copy link
Member

esprush commented Aug 3, 2020

just checked on the latest version and this works for me. @marcoscannabrava can you confirm?
cc: @manojVivek @jjavierdguezas @naher94 @rafaykhawar09 @ewazlak

think chrome 83 update handled this

@marcoscannabrava
Copy link
Author

Awesome! It's fixed.

@manojVivek manojVivek moved this from In progress to Ready for Release in App Roadmap Aug 4, 2020
@manojVivek manojVivek added this to the v0.10.0 milestone Aug 6, 2020
@manojVivek manojVivek moved this from Ready for Release to Release v0.10.0 in App Roadmap Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
App Roadmap
  
Release v0.10.0
Development

No branches or pull requests

7 participants