Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Address Bar suggestion keyboard interaction #338

Closed
manojVivek opened this issue Jul 20, 2020 · 7 comments · Fixed by #343
Closed

UX: Address Bar suggestion keyboard interaction #338

manojVivek opened this issue Jul 20, 2020 · 7 comments · Fixed by #343
Assignees
Labels
enhancement New feature or request
Projects
Milestone

Comments

@manojVivek
Copy link
Collaborator

manojVivek commented Jul 20, 2020

Add the usual drop-down's keyboard interactions for the address bar suggestions:

  1. Up and Down keys to highlight the items in the list
  2. Enter key to navigate to the highlighted URL.
@manojVivek manojVivek added the enhancement New feature or request label Jul 20, 2020
@manojVivek manojVivek added this to New in App Roadmap via automation Jul 20, 2020
@manojVivek manojVivek moved this from New to In progress in App Roadmap Jul 20, 2020
@karthick3018
Copy link
Contributor

@manojVivek thanks !

@manojVivek
Copy link
Collaborator Author

Also, we can add ESC key to close the suggestions.

@karthick3018
Copy link
Contributor

yeah that will be gud working on that too !

@abakermi abakermi mentioned this issue Jul 23, 2020
@manojVivek
Copy link
Collaborator Author

@abakermi This issue was already picked up by @karthick3018. It would have been great if you could have picked an un-assigned issue. :)

@karthick3018 Do you mind if we go ahead with @abakermi's PR?

@abakermi
Copy link
Contributor

@manojVivek sorry I have missed , if @karthick3018 not started , we go ahead and check

@karthick3018
Copy link
Contributor

karthick3018 commented Jul 23, 2020

@manojVivek your call manoj i've done 70% of work with downshift !

@manojVivek
Copy link
Collaborator Author

Ok @karthick3018, let's go with @abakermi's PR this time then.

You can check out the other issues that we have. :)

@karthick3018 karthick3018 removed their assignment Jul 24, 2020
@manojVivek manojVivek moved this from In progress to Ready for Release in App Roadmap Jul 27, 2020
@manojVivek manojVivek added this to the v0.9.0 milestone Jul 27, 2020
@manojVivek manojVivek linked a pull request Jul 29, 2020 that will close this issue
@manojVivek manojVivek moved this from Ready for Release to Release v0.9.0 in App Roadmap Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
App Roadmap
  
Release v0.9.0
Development

Successfully merging a pull request may close this issue.

3 participants