Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick screenshot option to capture the visible section(not full page) of the device #348

Closed
manojVivek opened this issue Jul 25, 2020 · 5 comments · Fixed by #361
Closed

Quick screenshot option to capture the visible section(not full page) of the device #348

manojVivek opened this issue Jul 25, 2020 · 5 comments · Fixed by #361
Assignees
@jzabala
Labels
enhancement New feature or request
Projects
App Roadmap
Milestone
v0.10.0

Comments

@manojVivek
Copy link
Collaborator

Add an icon to the device toolbar to enable this functionality.
@manojVivek manojVivek added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jul 25, 2020
@manojVivek manojVivek added this to New in App Roadmap via automation Jul 25, 2020
@manojVivek
Copy link
Collaborator Author

@rossmoody Any icon suggestion for this one?

@manojVivek manojVivek moved this from New to Higher-Priority Items in App Roadmap Jul 25, 2020
@jzabala
Copy link
Contributor

jzabala commented Jul 26, 2020

I'll like to work on this one. Let me know what icon to use for it.

@manojVivek
Copy link
Collaborator Author

@jzabala Great, assigning this to you. 🙌

@manojVivek manojVivek removed good first issue Good for newcomers help wanted Extra attention is needed labels Jul 27, 2020
@manojVivek manojVivek moved this from Higher-Priority Items to In progress in App Roadmap Jul 27, 2020
@jzabala jzabala mentioned this issue Jul 28, 2020
Merged
@manojVivek
Copy link
Collaborator Author

@jzabala We can go with the below svg for the icon:

<svg width="78" height="91" viewBox="0 0 78 91" fill="none" xmlns="http://www.w3.org/2000/svg">
<path fill="black" d="M29 25C28.2193 25.007 27.6091 25.4026 27.2812 25.9687L20.8438 37H8C3.6026 37 0 40.6026 0 45V83C0 87.3974 3.6026 91 8 91H70C74.3974 91 78 87.3974 78 83V45C78 40.6026 74.3974 37 70 37H57.1562L50.7188 25.9687C50.3641 25.3795 49.6877 24.9983 49 25H29ZM30.125 29H47.875L54.2812 40C54.6281 40.6007 55.3063 40.9953 56 41H70C72.2506 41 74 42.7494 74 45V83C74 85.2505 72.2506 87 70 87H8C5.74944 87 4 85.2505 4 83V45C4 42.7494 5.74944 41 8 41H22C22.6937 40.995 23.3719 40.6007 23.7188 40L30.125 29ZM39 47C30.1871 47 23 54.1871 23 63C23 71.8128 30.1871 79 39 79C47.8129 79 55 71.8128 55 63C55 54.1871 47.8129 47 39 47ZM39 51C45.6511 51 51 56.3489 51 63C51 69.6511 45.6511 75 39 75C32.3489 75 27 69.6511 27 63C27 56.3489 32.3489 51 39 51Z" />
<path d="M60 15.5L65 1H76.5L69.5 13H74.5L60 30.5L65 15.5H60Z" fill="black" stroke="black" stroke-width="2" stroke-linejoin="round"/>
</svg>

@jzabala
Copy link
Contributor

jzabala commented Jul 30, 2020 •
edited
Loading

@jzabala We can go with the below svg for the icon:

Awesome! Added to the PR @manojVivek 🙂

@manojVivek manojVivek added this to the v0.10.0 milestone Jul 31, 2020
@manojVivek manojVivek moved this from In progress to Ready for Release in App Roadmap Aug 2, 2020
@manojVivek manojVivek moved this from Ready for Release to Release v0.10.0 in App Roadmap Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzabala jzabala

Labels
enhancement New feature or request
Projects
No open projects
App Roadmap
  
Release v0.10.0
Milestone
v0.10.0
Development

Successfully merging a pull request may close this issue.

feat(desktop-app): add viewport screenshot option jzabala/responsively-app
2 participants
@manojVivek @jzabala