Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search device list by display size #613

Closed
romeo-folie opened this issue Jul 13, 2021 · 5 comments Β· Fixed by #630
Closed

Search device list by display size #613

romeo-folie opened this issue Jul 13, 2021 · 5 comments Β· Fixed by #630
Assignees
Labels
enhancement New feature or request
Projects
Milestone

Comments

@romeo-folie
Copy link

πŸš€ Feature Request

πŸ“ Description

The device list should be searchable by display size.

✨ Describe the solution you'd like

It would be extremely convenient if a user could also search the list of devices by display size. For instance, I'd expect to see the iPad Pro when I input "1024 x"

@open-collective-bot
Copy link

Hey @romeo-folie πŸ‘‹,

Thank you for opening an issue. We will get back to you as soon as we can. Have you seen our Open Collective page? Please consider contributing financially to our project. This will help us involve more contributors and get to issues like yours faster.

https://opencollective.com/responsively

We offer priority support for all financial contributors. Don't forget to add priority label once you become one! πŸ˜„

@jjavierdguezas jjavierdguezas added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Aug 30, 2021
@kiwan97
Copy link
Contributor

kiwan97 commented Aug 31, 2021

@jjavierdguezas
Hello!
I carried out one issue about a year ago.
I'd like to try this issue :)

"Manage Devces > Active Devices, Inactive Devices with search...(text input)"
Is that screen related to the issue correct?

If a number is entered on that input, should I show the device of the relevant size?
ex) "1000" => search every "1000 x ???" or "??? x 1000" screen device.
ex) "100" => search eveny "100 x ???" or "??? x 100" or "1000 x ???" or "??? x 1000" screen device.

Should I find a device that's close to number?
ex) "1000" => "1014 x 1524", "2014x999" screen device.

Thanks.

@jjavierdguezas
Copy link
Contributor

@jjavierdguezas
Hello!
I carried out one issue about a year ago.
I'd like to try this issue :)

"Manage Devces > Active Devices, Inactive Devices with search...(text input)"
Is that screen related to the issue correct?

If a number is entered on that input, should I show the device of the relevant size?
ex) "1000" => search every "1000 x ???" or "??? x 1000" screen device.
ex) "100" => search eveny "100 x ???" or "??? x 100" or "1000 x ???" or "??? x 1000" screen device.

Should I find a device that's close to number?
ex) "1000" => "1014 x 1524", "2014x999" screen device.

Thanks.

Hi @kiwan97
Maybe put another search box for active devices:
image

and also include the width and height in the filter here (as strings), I don't think it is necessary to do something more complicated here

image

what do you think @manojVivek

@jjavierdguezas jjavierdguezas removed help wanted Extra attention is needed good first issue Good for newcomers labels Sep 1, 2021
@jjavierdguezas jjavierdguezas added this to New in App Roadmap via automation Sep 1, 2021
@jjavierdguezas
Copy link
Contributor

I am thinking about this again, and maybe @romeo-folie was talking about the quick filters? πŸ€”

image

image

@romeo-folie
Copy link
Author

Hi. No, I wasn't talking about the quick filters. I was referring to the search input above the list of inactive devices. The way I imagine it working is that a user enters a dimension value for the device they want and the list of devices is filtered to only show devices with that width or height. Say I enter 1000, any device with dimensions 1000 x ??? or ??? x 1000 should be included in the filtered list.

@jjavierdguezas jjavierdguezas moved this from New to Ready for Release in App Roadmap Oct 14, 2021
@manojVivek manojVivek added this to the v0.18.0 milestone Oct 14, 2021
@manojVivek manojVivek moved this from Ready for Release to Release v0.18.0 in App Roadmap Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
App Roadmap
  
Release v0.18.0
Development

Successfully merging a pull request may close this issue.

4 participants