Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port tests to RSpec3 #108

Closed
wants to merge 3 commits into from
Closed

Port tests to RSpec3 #108

wants to merge 3 commits into from

Conversation

balasankarc
Copy link

No description provided.

@yaauie
Copy link
Member

yaauie commented Oct 5, 2015

Thanks! I'm in favor of bumping the rspec development dependency in the gemspec, too; could you add that to your PR?

@balasankarc
Copy link
Author

Sure. Will update the PR.

@balasankarc
Copy link
Author

@yaauie Can you check why Travis CI fails? It succeeded in Ruby 1.8.7 and 1.9.2

@yaauie
Copy link
Member

yaauie commented Dec 21, 2015

I've kicked the build; one failed because the CI server failed to bundle install, and the other failed because the CI failed to install rubinius.

@fw42
Copy link
Member

fw42 commented Aug 5, 2016

CI should be fixed now. Can you rebase and try again?

@rafaelfranca
Copy link
Member

Fixed in a different commit. Thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@balasankarc @yaauie @fw42 @rafaelfranca