Add failing test for nonexistent Redis commands #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy
reviewed
May 29, 2019
|
@jeremy for now, redis-namespace supports version 3.0.4 and greater. I've checked versions v4.0.0, v3.0.0, v2.0.0, v1.0.0 and v0.2.0 of redis-rb and none of them responds to Code was added in 1e8a532 and I see no reasons why |
|
Sounds good, @jbmeerkat. Thanks for verifying! Let's go ahead and remove the failing tests, then 😊 |
redis-namespace delegates `[]` and `[]=` to redis-rb client, but it doesn't respond to these methods. All the previous versions down to 0.2.0 doens't respond too. Removed `[]` and `[]=` delegation.
|
@jeremy removed test and squashed in one commit. Should I also update changelog or something? |
|
Thanks @jbmeerkat! We'll manage that as part of the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no
[]and[]=commands in Redis, but redis-namespace responds to those methods. If you try to call one of them — Redis will fail with "Redis::CommandError: ERR unknown command '[]'" or "Redis::CommandError: ERR unknown command '[]'" depending of the command.