Limit method_missing to only handle known commands #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redis-Namespace has had a *long* history of issues rising from the blind
passing of unknown commands to the underlying Redis Client (see almost
every single issue in the [tracker][]). This patch is a breaking change
that stops that behaviour, instead raising a NoMethodError when handling
a command that is unknown.
TODO before 2.x release:
- [ ] Add support & specs for Command Aliases
- [ ] Define all methods to avoid method_missing altogether
(via `Module#define_method`?)
[tracker]: https://github.com/resque/redis-namespace/issues?state=closed
Pairing session with @chelseakomlo and @yaauie.
Support for command aliases was dropped in redis-rb 2.0, and we have been requiring redis-rb 3.x for a while now, so the referenced code is orphaned and *never* used.
yaauie
added a commit
that referenced
this pull request
Dec 5, 2013
Only wrap known commands, eliminating the root cause of the vast majority of past issues in this project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redis-Namespace has had a long history of issues rising from the blind
passing of unknown commands to the underlying Redis Client (see almost
every single issue in the tracker). This patch is a breaking change
that stops that behaviour, instead raising a NoMethodError when handling
a command that is unknown.
TODO before merge and 2.x release:
Add support & specs for Command AliasesRedis-RB hasn't supported these since 2.0, we require 3.0 as a minimum.(via
Module#define_method?)Pairing session with @chelseakomlo and @yaauie.