enqueue_delayed_selection #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tbprojects Sorry about the delay! The master branch has been fixed so that you should no longer have those GC-related test failures. Are you able to rebase against master, or at least merge in master? |
|
@tbprojects Thank you so much for the contribution, btw! ❤️ |
|
Hi @meatballhat, now I have to say sorry for a delay ;) I rebased againts master and it's good to merge. |
|
@tbprojects find_delayed_selection is exactly what I need, thanks! |
|
@codalicious great to hear that :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the nice features is
remove_delayed_selectionwhich allows to filter jobs to be removed. I needed similar filtration functionality but for immediate enqueuing delayed jobs, that are already queued.In addition I extracted filtration to separate method -
find_delayed_selection