Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-deprecated form of Redis.sadd/srem #752

Merged

Conversation

irvingreid
Copy link
Contributor

This fixes the deprecation warnings for Redis#sadd and Redis#srem output by version 4.8 of redis-rb, following the example of the changes made to Resque in resque/resque#1827

Other tests failed when upgrading redis-rb to 5.0.4, which is why I added the restriction to resque-scheduler.gemspec

To avoid future regressions, I enabled Redis.raise_deprecations = true so that the test suite is more likely to catch future Redis deprecations.

@irvingreid
Copy link
Contributor Author

Looks like your test matrix pairs Redis 4.8 with older versions of the resque gem, which trigger deprecation failures. Would you rather change the test matrix, or remove Redis.raise_deprecations = true?

@irvingreid
Copy link
Contributor Author

@PatrickTulskie removed the gemspec change here too, because the main branch fixed Redis 5.0 compatibility :-)

@carlwiedemann
Copy link

Friendly bump. Is there anything preventing this from getting merged?

@PatrickTulskie PatrickTulskie self-requested a review May 9, 2023 13:35
@PatrickTulskie PatrickTulskie merged commit cb67a44 into resque:master May 25, 2023
@irvingreid irvingreid deleted the fix-redis-sadd-deprecations branch June 28, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants