improve resque's tests description and remove 'should'

test/resque/coder_test.rb

@@ -6,7 +6,7 @@
   end
 
   describe '#encode' do
-    it 'should raise an exception' do
+    it 'raises an exception' do
       assert_raises(Resque::EncodeException) {@coder.encode(nil)}
     end
 
@@ -16,12 +16,12 @@
   end
 
   describe '#decode' do
-    it 'should raise an exception' do
+    it 'raises an exception' do
       assert_raises(Resque::DecodeException) {@coder.decode(nil)}
     end
 
-    it 'aliased #load should raise an exception' do
+    it 'aliased #load raises an exception' do
       assert_raises(Resque::DecodeException) {@coder.load(nil)}
     end
   end
-end
+end

test/resque/config_test.rb

@@ -6,7 +6,7 @@
     describe 'with empty hash' do
       let(:args_hash) { {} }
 
-      it 'should initialize' do
+      it 'initializes' do
         Resque::Config::new(args_hash)
       end
     end

test/resque/failure/each_test.rb

@@ -7,7 +7,7 @@
   end
 
   describe 'each' do
-    it 'should properly iterate over the default range for a single failure' do
+    it 'properly iterates over the default range for a single failure' do
       save_failures('T1')
 
       n = 0
@@ -20,7 +20,7 @@
       assert_equal 1, n
     end
 
-    it 'should properly iterate over the default range for multiple failures' do
+    it 'properly iterates over the default range for multiple failures' do
       expected_failure_classes = ['T1', 'T2']
       save_failures('T1', 'T2')
 
@@ -34,7 +34,7 @@
       assert_equal 2, n
     end
 
-    it 'should properly iterate over the specified range for multiple failures' do
+    it 'properly iterates over the specified range for multiple failures' do
       save_failures('T1', 'T2', 'T3')
 
       n = 0
@@ -47,7 +47,7 @@
       assert_equal 1, n
     end
 
-    it 'should only find the desired classes of errors' do
+    it 'only finds the desired classes of errors' do
       save_failures('T1', 'T2')
 
       n = 0
@@ -60,7 +60,7 @@
       assert_equal 1, n
     end
 
-    it 'should only find the desired classes of errors within the specified range' do
+    it 'only finds the desired classes of errors within the specified range' do
       save_failures('T1', 'T2', 'T2', 'T3')
 
       n = 0

test/resque/failure/redis_multi_queue_test.rb

@@ -12,7 +12,7 @@
   end
 
   describe '#requeue' do
-    it 'should requeue a new job to the queue of the failed job' do
+    it 'requeues a new job to the queue of the failed job' do
       save_failure
 
       failure = Resque::Failure::RedisMultiQueue.all(0, 1, :failed_failed).first
@@ -30,7 +30,7 @@
   end
 
   describe '#requeue_queue' do
-    it 'should requeue all failures for the desired queue' do
+    it 'requeues all failures for the desired queue' do
       save_failure('queue1')
       save_failure('queue2')
       save_failure('queue1')
@@ -49,7 +49,7 @@
   end
 
   describe '#remove_queue' do
-    it 'should remove all failures for the desired queue' do
+    it 'removes all failures for the desired queue' do
       save_failure('queue1')
       save_failure('queue2')
       save_failure('queue1')
@@ -64,7 +64,7 @@
   end
 
   describe '#clear' do
-    it 'should remove all failures in a given queue' do
+    it 'removes all failures in a given queue' do
       save_failure('queue1')
       save_failure('queue1')
 
@@ -75,7 +75,7 @@
   end
 
   describe '#remove' do
-    it 'should remove an individual failure from the given queue' do
+    it 'removes an individual failure from the given queue' do
       save_failure('queue1')
 
       assert_equal 1, Resque::Failure.count('queue1_failed')
@@ -85,7 +85,7 @@
   end
 
   describe '#queues' do
-    it 'should list all known failure queues' do
+    it 'lists all known failure queues' do
       assert_empty Resque::Failure::RedisMultiQueue.queues
 
       save_failure('queue1')
@@ -98,15 +98,15 @@
   end
 
   describe '#count' do
-    it 'should count all failures across all failure queues' do
+    it 'counts all failures across all failure queues' do
       save_failure('queue1')
       save_failure('queue2')
       save_failure('queue3')
 
       assert_equal 3, Resque::Failure::RedisMultiQueue.count
     end
 
-    it 'should count all failures for the given queue and class' do
+    it 'counts all failures for the given queue and class' do
       save_failure('queue1', 'some_class')
       save_failure('queue1', 'another_class')
       save_failure('queue1', 'another_class')

test/resque/failure/redis_test.rb

@@ -7,15 +7,15 @@
   end
 
   describe '#count' do
-    it 'should count all failures' do
+    it 'counts all failures' do
       save_failure
       save_failure
       save_failure
 
       assert_equal 3, Resque::Failure::Redis.count
     end
 
-    it 'should count all failures for the given queue and class' do
+    it 'counts all failures for the given queue and class' do
       save_failure(:failed, 'some_class')
       save_failure(:failed, 'another_class')
       save_failure(:failed, 'another_class')
@@ -26,13 +26,13 @@
   end
 
   describe '#queues' do
-    it 'should return the failure queue' do
+    it 'returns the failure queue' do
       assert_equal [:failed], Resque::Failure::Redis.queues
     end
   end
 
   describe '#requeue' do
-    it 'should requeue a new job to the queue of the failed job' do
+    it 'requeues a new job to the queue of the failed job' do
       save_failure
 
       failure = Resque::Failure::Redis.all.first
@@ -50,7 +50,7 @@
   end
 
   describe '#requeue_to' do
-    it 'should requeue a new job to the desired queue' do
+    it 'requeues a new job to the desired queue' do
       save_failure
 
       failure = Resque::Failure::Redis.all.first
@@ -68,7 +68,7 @@
   end
 
   describe '#requeue_queue' do
-    it 'should requeue all failures for the desired queue' do
+    it 'requeues all failures for the desired queue' do
       save_failure('queue1')
       save_failure('queue2')
       save_failure('queue1')
@@ -87,7 +87,7 @@
   end
 
   describe '#remove_queue' do
-    it 'should remove all failures for the desired queue' do
+    it 'removes all failures for the desired queue' do
       save_failure('queue1')
       save_failure('queue2')
       save_failure('queue1')

test/resque/process_coordinator_test.rb

@@ -16,7 +16,7 @@
   describe "#worker_pids" do
     let(:process_coordinator) { Resque::ProcessCoordinator.new }
 
-    it "should return worker pids for each OS" do
+    it "returns worker pids for each OS" do
       Resque::ProcessCoordinator.stub_const(:RUBY_PLATFORM, "solaris") do
         process_coordinator.stub :`, SOLARIS_RESPONSE do
           assert_equal process_coordinator.worker_pids, ["11111"]
@@ -36,7 +36,7 @@
       end
     end
 
-    it "should raise error if fail to execute cmd" do
+    it "raises error if fail to execute cmd" do
       def process_coordinator.`(cmd)
         raise RuntimeError
       end
@@ -46,4 +46,4 @@ def process_coordinator.`(cmd)
       }
     end
   end
-end
+end