Remove old heartbeats before starting heartbeat thread #1488
+21
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
:( I don't have any other ideas on the race. This doesn't seem crazy regardless, so I'm ok with it. |
|
👍 |
|
something is weird with travis CI.. same error as the other branch.. unrelated to the changes here |
|
confirmed in production that this solves the errors I was seeing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like #1485 did not fix the issue fully. I'm still seeing some PruneDeadWorker exceptions in production, which leads me to believe that there is still a race condition. Sadly I'm not really sure what the race condition is though :-(
This PR should once and for all fix it, by explicitly removing old heartbeats (of the same worker id) before sending any new heartbeats (and before registering the worker).
@dylanahsmith @sirupsen