Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow http-accept 2 #762

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jaredbeck
Copy link

@jaredbeck jaredbeck commented Jul 12, 2021

Fixes #750

@TomA-R
Copy link

TomA-R commented Oct 1, 2021

Hey @adamwiggins, apologies for the direct ping but it seems like you might be the only remaining active maintainer of this gem. Any chance you could merge and release this? Thanks in advance!

@adamwiggins
Copy link
Contributor

Hmm interesting, I'm not active—haven't written a line of code here in 10+ years. Happy to hand over maintenance to whoever wants to pick it up.

@jaredbeck
Copy link
Author

Happy to hand over maintenance to whoever wants to pick it up.

Hi Adam, I can help. I maintain PaperTrail and Authlogic. I use RestClient at work, but only as a transitive dependency of Mailgun. So, my maintenance efforts here would be limited to critical issues only: security, and dependency upgrades like this PR. The first thing I'd probably do (even before merging this PR) would be setting up CI.

@TomA-R
Copy link

TomA-R commented Oct 5, 2021

Thank you both, I think that would be a really good way forward

@adamwiggins
Copy link
Contributor

Heh, so I just realized I don't have any special permissions here on the rest-client top-level account. Sorry, maybe @mattmanning can help?

@n-rodriguez
Copy link

n-rodriguez commented Oct 16, 2021

The first step would have been : #754 but I don't think this will happen. I'm a bit pessimistic about the future of this gem as nobody seems to care.

@TomA-R
Copy link

TomA-R commented Oct 21, 2021

hey @adamwiggins, would you be willing to review/merge a couple of small, maintenance-related PRs (and cut+push a new release)? Fixing CI and bumping/loosening dependencies would be good enough for me really.

Thanks so much in advance, it would really help us a lot.

@n-rodriguez
Copy link

@TomA-R

so I just realized I don't have any special permissions here on the rest-client top-level account.

@n-rodriguez
Copy link

n-rodriguez commented Oct 21, 2021

@TomA-R @jaredbeck Why down thumbing my answer? Really, I'd like to know?

Does this mean I can't express my opinion about the future of this gem? I really don't understand people like you.

@n-rodriguez
Copy link

n-rodriguez commented Oct 21, 2021

Thank you both, I think that would be a really good way forward

@TomA-R So this wasn't a good way forward?

@TomA-R
Copy link

TomA-R commented Oct 21, 2021

Hi Nicolas, I have no problem with your PR (in fact, I think it's a good idea, thanks for contributing!). I don't share your pessimism though - we seem to have Adam's attention, even if he doesn't have access to add maintainers.

@n-rodriguez
Copy link

@TomA-R the only 3 people allowed to add committers https://github.com/rest-client @ab (@brodygov) @L2G @mattmanning

@n-rodriguez
Copy link

I've been pinging them litterally for years with no answers, never, even by mail. Thus my pessimism.

@n-rodriguez
Copy link

Since #715 everybody left the project.

@TomA-R
Copy link

TomA-R commented Oct 21, 2021

The Github orgs 'people' page doesn't list everyone who has write access to the repo, but you're right, it was a bit of a bold assumption that Adam may be able to help (that was based on who owns Rubygems). So what are the alternatives? Create a fork and publish it to Rubygems? rest-client2?

@n-rodriguez
Copy link

Really I don't know... You're the first one to show interest in this gem I've met.

@n-rodriguez
Copy link

n-rodriguez commented Oct 21, 2021

Even @ioquatix (a ruby core committer/developper) gave up : #721 (comment)

@TomA-R
Copy link

TomA-R commented Oct 21, 2021

I'd say let's give it a couple of weeks, maybe @adamwiggins has some magic up his sleeve and otherwise fork the project? What do you think?

@n-rodriguez
Copy link

n-rodriguez commented Oct 21, 2021

I'd say let's give it a couple of weeks, maybe @adamwiggins has some magic up his sleeve and otherwise fork the project? What do you think?

Sure, I've been waiting longer than that 😄 (I'm following this PR since its creation)

That said I'm really sad about the situation.

@n-rodriguez
Copy link

https://github.com/jbox-web/rest-client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency http-accept
4 participants