Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRestEveEventViewer. GEOM_SCALE is set to 1 for any ROOT version #103

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

jgalan
Copy link
Member

@jgalan jgalan commented Sep 21, 2021

jgalan 0 Powered by Pull Request Badge

  • At Refactoring #44 it was updated the GEOM_SCALE from 0.1 to 1 for ROOT versions above 6.24. However, I am using ROOT 6.20 and the hits did not appear at the right position inside the geometrical volumes. Applying this PR update fixes the problem for me.

Not sure if the problem could be connected with the fact that I generated the data in sultan using ROOT 6.24, and then visualised on my local PC with ROOT 6.20.

@rest-for-physics/core_dev

@jgalan jgalan requested review from juanangp, lobis and a team September 21, 2021 15:11
@jgalan jgalan merged commit d2fdc6e into master Sep 22, 2021
@jgalan jgalan deleted the eve_viewer_geo_scale branch September 22, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant