Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Garfield compilation fix #158

Merged
merged 3 commits into from
Mar 23, 2022
Merged

Garfield compilation fix #158

merged 3 commits into from
Mar 23, 2022

Conversation

jgalan
Copy link
Member

@jgalan jgalan commented Mar 22, 2022

jgalan 9

CMakeLists fixes related to Garfield compilation of old versions.

Related to #37

Copy link
Member

@lobis lobis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are fine (I took the opportunity to make some formatting changes and remove old comments).

However it doesn't make sense that this file suddenly stops working, there must be a problem with the sultan installation of Garfield I think. For example, at /programas/garfield/6.24.02 there are two "includes", one include and one Include, something must be wrong.

I would reinstall the same version of Garfield and check if this PR is really needed before merging.

Or just install the latest Garfield version and work with that, and probably drop support for old Garfield altogether, which will save time on the long run I think.

@jgalan
Copy link
Member Author

jgalan commented Mar 22, 2022

The good one is include, it is the one generated by the installation. Include is the one from the sources. Both should have the same content anyway. This happens because the install path is defined as GARFIELD_HOME. I believe this is because it was like that at the original installation instructions of Garfield.

The changes happening at this PR had no effect on solving my compilation problem. The problem was solved at detectorlib. The reason behind is that the include directories were not the right ones.

@jgalan jgalan requested review from juanangp and nkx111 March 22, 2022 19:37
@jgalan jgalan merged commit 252286d into master Mar 23, 2022
@jgalan jgalan deleted the jgalan_garfield_fix branch March 23, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants