Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minimum CMake version to 3.16 #200

Merged
merged 6 commits into from
May 12, 2022
Merged

Bump minimum CMake version to 3.16 #200

merged 6 commits into from
May 12, 2022

Conversation

lobis
Copy link
Member

@lobis lobis commented May 8, 2022 •
edited
Loading

@lobis lobis changed the title Lobis cmake 162 Bump minimum CMake version to 3.16 May 10, 2022
@lobis lobis requested review from jgalan, juanangp, nkx111 and a team May 10, 2022 09:14
@lobis lobis marked this pull request as ready for review May 10, 2022 09:14
@juanangp
Copy link
Member

I have found that the required cmake version is used in other packages/libraries:
image
Shall we also update them @jgalan @lobis ?

@jgalan
Copy link
Member

jgalan commented May 10, 2022 •
edited
Loading

Perhaps we could have a common file at cmake/ that contains common definitions for any CMakeLists.txt and we just use include( CommonDefinitions) or similar?

@lobis
Copy link
Member Author

lobis commented May 10, 2022

Perhaps we could have a common file at cmake/ that contains common definitions for any CMakeLists.txt and we just use include( CommonDefinitions) or similar?

No, we need to have the same line across all the repos if we want to allow the compilation of each library separate from the framework (compile a library using the system installed version of REST). Hopefully this won't change for a while.

lobis added a commit to rest-for-physics/restG4 that referenced this pull request May 10, 2022
@lobis
Bumped min cmake version to 3.16 when standalone (rest-for-physics/fr…
e10172e 
…amework#200)
@lobis
Copy link
Member Author

lobis commented May 11, 2022

@jgalan can you approve this PR please? ty

@jgalan jgalan merged commit c4dd136 into master May 12, 2022
@jgalan jgalan deleted the lobis-cmake-162 branch May 12, 2022 08:39
@lobis lobis mentioned this pull request May 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgalan jgalan jgalan approved these changes

@juanangp juanangp juanangp approved these changes

@nkx111 nkx111 Awaiting requested review from nkx111 nkx111 is a code owner

Assignees

@jgalan jgalan

@juanangp juanangp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increasing minimum CMake version causes problems on install
3 participants
@lobis @juanangp @jgalan