pull-submodules.py update for -latest flag #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lobis
requested changes
May 10, 2022
pull-submodules.py
Outdated
| @@ -177,10 +177,10 @@ def main(): | |||
| branchToPull = "master" | |||
| if branchExistsPcs.stdout.decode("utf-8").rstrip("\n") != "0": | |||
| branchToPull = frameworkBranchName | |||
| print(" --> Pulling branch : " + branchToPull + " ", end='') | |||
| print(" --> Pulling branch : " + branchToPull + " ", end='') | |||
There was a problem hiding this comment.
Just a reminder that we should use Python f-strings whenever possible 👍🏻
Suggested change
| print(" --> Pulling branch : " + branchToPull + " ", end='') | |
| print(f" --> Pulling branch: {branchToPull}", end='') |
There was a problem hiding this comment.
Just a reminder that we should use Python f-strings whenever possible 👍🏻
@DavidDiezIb did you click on "commit suggestion" or did you write the commit yourself? just wondering in case you are not aware that you can accept suggestions from the web gui
There was a problem hiding this comment.
I did it myself, good to know for the next time ;)
|
Hi @DavidDiezIb what about the pulling the branch change forcing that each submodule has a local branch and is thus not detached? |
DavidDiezIb
commented
May 11, 2022
|
Why this PR was not yet merged? |
jgalan
approved these changes
May 17, 2022
juanangp
approved these changes
May 23, 2022
|
@lobis merging seems to be blocked by you |
jgalan
approved these changes
May 23, 2022
lobis
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pull-submodules.py update to consider recent commits in branches when using -latest flag.
Print which branch is pulling from.