Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format rml files in a similar way as clang format #208

Merged
merged 10 commits into from
May 13, 2022
Merged

Format rml files in a similar way as clang format #208

merged 10 commits into from
May 13, 2022

Conversation

lobis
Copy link
Member

@lobis lobis commented May 12, 2022 •
edited by pull-request-badge bot
Loading

lobis Ok: 50

Fixes #205

@lobis lobis linked an issue May 12, 2022 that may be closed by this pull request
Format rml files in a similar way as clang-format #205
Closed
2 tasks
@juanangp juanangp mentioned this pull request May 12, 2022
Closed
@juanangp
Copy link
Member

Shall we drop the support for directories in this script? I think, shouldn't bee necessary after implementing hooks #209

@lobis
Copy link
Member Author

lobis commented May 13, 2022

Shall we drop the support for directories in this script? I think, shouldn't bee necessary after implementing hooks #209

I don't think so, people (like me) would still want to use it for formatting the whole project tree, and I cannot use this cmake hook due to remote build :(

@juanangp
Copy link
Member

I don't think so, people (like me) would still want to use it for formatting the whole project tree, and I cannot use this cmake hook due to remote build :(

Ok, fair enough

@lobis lobis requested a review from juanangp May 13, 2022 07:34
@lobis lobis marked this pull request as ready for review May 13, 2022 07:35
@juanangp juanangp requested a review from jgalan May 13, 2022 08:32
@lobis lobis merged commit e20fc0e into master May 13, 2022
@lobis lobis deleted the 205-format-rml-files-in-a-similar-way-as-clang-format branch May 13, 2022 10:04
This was referenced May 25, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgalan jgalan jgalan approved these changes

@juanangp juanangp juanangp approved these changes

Assignees

@juanangp juanangp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Format rml files in a similar way as clang-format
3 participants
@lobis @juanangp @jgalan