New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around to avoid return when test are enabled #228

Merged

juanangp merged 1 commit into master from issue169

May 25, 2022

Member

juanangp commented May 25, 2022 •

edited by pull-request-badge bot

Potential fix for #169

Now REST_PATH is not set in case of testing are enabled. I checked that is working fine with the test currently implemented, however we might have potential issues in case REST_PATH is required. However, REST_PATH cannot be set during test since installation path is not present at this stage...
Doesn't change the logic when test are disabled.
Added newRESTError and RESTWarning functions instead of std::cout


          Work around to avoid return when test are enabled

3fe0d32

juanangp requested review from jgalan, nkx111 and lobis

May 25, 2022 11:10

lobis approved these changes

View reviewed changes

jgalan approved these changes

View reviewed changes

juanangp merged commit dd71405 into master

juanangp deleted the issue169 branch

May 25, 2022 16:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment