Using whoami when USER is not defined instead of default user
#241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pipeline is failing due to some other reason. This works locally. |
juanangp
approved these changes
Jun 6, 2022
This is because I mistakenly merged the PR rest-for-physics/restG4#49 in restG4. It changes a variables which is available in PR #231. So it should be merged only after the framework PR is merged. Shall we revert restG4 or merge the framework? |
cmargalejo
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if the
USERenvironment variable is not set,defaultUseris set asUSER.This PR makes use of
whoami(which also exists on windows apparently) to get the current username, which is not always present in the environtment variable. TheUSERenv variable will still take precendence.If for some reason
whoamiis not found, it will still usedefaultUserand it won't raise an exception.