Reorganizing projects directory #247
Conversation
|
The pipeline fails with |
| @@ -75,7 +75,7 @@ Validate Code: | |||
| stage: pre-build | |||
| script: | |||
| - cd ${CI_PROJECT_DIR}/ | |||
| - python3 pull-submodules.py --force --dontask --latest:${CI_COMMIT_BRANCH} | |||
| - python3 pull-submodules.py --force --dontask --latest:${CI_COMMIT_BRANCH} --exclude:iaxo,detector-template | |||
There was a problem hiding this comment.
Shouldn't be included inside lfna?
There was a problem hiding this comment.
Include what inside lfna?
There was a problem hiding this comment.
lfna projects are optional, they will be pulled only if we add the option --lfna
There was a problem hiding this comment.
If we do not need them for the pipelines, we better do not pull them
There was a problem hiding this comment.
Indeed, these are not under lfna, what I meant is if would be a good idea to add projects option to pull-submodules.py following the new projects structure.
There was a problem hiding this comment.
Not sure if I got exactly what you want
There was a problem hiding this comment.
Something like
- python3 pull-submodules.py --force --dontask --latest:${CI_COMMIT_BRANCH} --projects
Otherwise the projects are excluded by default, or the other way around
|
Can you post in the PR description the link to the different projects? It is a bit difficult to follow up, particularly the ones under |
In principle if you got directly to the branch https://github.com/rest-for-physics/framework/tree/jgalan_projects you may check |
|
Can you merge master in this branch, at least to see if build passes. Pipeline currently has other issues that I am afraid should be addressed somewhere else. |
|
Wow I merged! And GitHub Pipeline was red! |
Well, we have to configure the master branch settings to block PR in case that the pipeline fails. It is not yet configured. We should define the checks that are required and we can force the merge with master. |
|
Aham, but the other day I had the impression the PR was blocked by the checks. |
This PR intention is to reorganize the projects directory. Now a main project directory is linked to the framework, while the project may contain additional submodules, or structure.
The following projects are linked :
detector-template: A set of project template repositories that can be used as reference to create new projects. Hosted at GitHub/rest-for-physics.basic-examples: A collection of examples for each of the specific domains, readouts, geometries, simulations, etc. Hosted at rest-for-physics.alphacamm: Hosted at LFNA. https://lfna.unizar.es/gifna/alphacammtrexdm: Hosted at LFNA. https://lfna.unizar.es/gifna/trexdm-projectiaxo: Hosted at GitHub/iaxo.