Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates #263

Merged
merged 10 commits into from
Jul 12, 2022
Merged

Minor updates #263

merged 10 commits into from
Jul 12, 2022

Conversation

lobis
Copy link
Member

@lobis lobis commented Jul 11, 2022

lobis Ok: 88

In this PR I introduce small changes motivated by other PRs.

  • Using std::filesystem::weakly_canonical to save the output file path inside TRestRun after "forming". Saving the path as a canonical absolute path helps solve a bug showing the wrong path at the end of simulation when launching from the IDE. Currently paths are being stored with things such as "./", these things are now resolved before storing and the path is absolute.
  • TRestHits no longer inherits from TObject as this is not necessary unless we want to store the hits directly in the root file, but we always save the class containing the hits, such as a TRestEvent. This reduces the members of the class which reduces the visual clutter when using the root explorer. Also TRestHits::RemoveHits is now virtual so it can be overriden in other classes.
  • All data members of TRestHits such as fNHits have been made protected instead of public and should be accessed by the corresponding getter which already existed before this PR.

Related PR:

@lobis lobis requested review from jgalan and juanangp July 11, 2022 09:49
@lobis lobis marked this pull request as ready for review July 11, 2022 09:51
@lobis lobis requested a review from juanangp July 11, 2022 10:06
@jgalan jgalan self-requested a review July 11, 2022 10:12
@lobis lobis merged commit d42b180 into master Jul 12, 2022
@lobis lobis deleted the lobis-minor-updates branch July 12, 2022 08:56
jgalan added a commit that referenced this pull request Aug 31, 2022
…ates"

This reverts commit d42b180, reversing
changes made to d1a9e8c.
@jgalan jgalan restored the lobis-minor-updates branch September 1, 2022 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants