Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reference root files in validation for PandaX #273

Merged
merged 46 commits into from
Sep 14, 2022

Conversation

lobis
Copy link
Member

@lobis lobis commented Jul 27, 2022

lobis Large: 254

This PR introduces a few necessary changes for rest-for-physics/geant4lib#59 and rest-for-physics/restG4#58.

  • The PandaX-III example was updated including the binary reference file.
  • Pipeline is updated.
  • Some minor refactoring.

@lobis
Copy link
Member Author

lobis commented Jul 28, 2022

I am attempting to solve the pipeline failure for rest-for-physics/geant4lib#59 by recreating the PandaX-III reference file but after many tried I cannot fix the error. I tried to have this file generated as an artifact so we don't have to manually generate it every time it needs updating but it also fails.

Perhaps @nkx111 @jgalan or @juanangp have some thoughts?

Maybe this step of the pipeline could be simplified or is already covered in some other step and it can be removed?

@lobis lobis requested review from juanangp, nkx111 and jgalan and removed request for juanangp July 28, 2022 10:40
@lobis
Copy link
Member Author

lobis commented Jul 29, 2022

Could you please take a look into this @nkx111 ? Thanks

@lobis lobis marked this pull request as ready for review September 10, 2022 18:56
@jgalan
Copy link
Member

jgalan commented Sep 14, 2022

Shall it be merged?

@lobis lobis merged commit d8eda7d into master Sep 14, 2022
@lobis lobis deleted the lobis-prepare-for-multithreading branch September 14, 2022 16:49
@jgalan jgalan mentioned this pull request Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants