Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRestPhysics.h added parabolic/hyperbolic interaction #281

Merged
merged 10 commits into from
Aug 26, 2022

Conversation

jovoy
Copy link
Contributor

@jovoy jovoy commented Aug 23, 2022

jovoy Medium: 100

Adding the interaction between a vector and a parabolic/hyperbolic shaped mirror:

  • Find interaction point between vector and parabolic mirror
  • Find interaction point between vector and hyperbolic mirror
  • normal vector on parabolic mirror
  • normal vector on hyperbolic mirror
  • the latter need to be normalized for further calculations

@jgalan
Copy link
Member

jgalan commented Aug 25, 2022

Hi @jovoy I just pushed a commit to fix the compilation issues, and fix the pipeline.

The badges you can see at the PR description will lead you to the output with the pipeline error and

Following the red crosses you get here https://gitlab.cern.ch/rest-for-physics/framework/-/jobs/24120940

Co-authored-by: Javier Galan <javier.galan@unizar.es>
@jovoy jovoy marked this pull request as ready for review August 26, 2022 10:00
@jgalan jgalan self-requested a review August 26, 2022 10:07
@jgalan jgalan requested review from jgalan and Vindaar August 26, 2022 10:07
Copy link
Member

@Vindaar Vindaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor typos. Otherwise looks good (even if root1 and root2 could ideally use a separately computed value for the sqrt, but that's being extra pedantic of course :) ).

source/framework/tools/inc/TRestPhysics.h Outdated Show resolved Hide resolved
source/framework/tools/src/TRestPhysics.cxx Outdated Show resolved Hide resolved
source/framework/tools/src/TRestPhysics.cxx Outdated Show resolved Hide resolved
Co-authored-by: Vindaar <basti90@gmail.com>
@jovoy jovoy merged commit d305f75 into master Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants