-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TRestPhysics.h added parabolic/hyperbolic interaction #281
Conversation
Hi @jovoy I just pushed a commit to fix the compilation issues, and fix the pipeline. The badges you can see at the PR description will lead you to the output with the pipeline error and Following the red crosses you get here https://gitlab.cern.ch/rest-for-physics/framework/-/jobs/24120940 |
Co-authored-by: Javier Galan <javier.galan@unizar.es>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor typos. Otherwise looks good (even if root1
and root2
could ideally use a separately computed value for the sqrt
, but that's being extra pedantic of course :) ).
Co-authored-by: Vindaar <basti90@gmail.com>
Adding the interaction between a vector and a parabolic/hyperbolic shaped mirror: