Fix not ignoring restG4
library on restRoot
#299
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently
TRestTools
was mofidied (#295) to fix an error on the GitLab pipeline. The fix removed the case insensitive flag for the comparison of the ignored libraries (since we didn't remember why it was there in the first place) but this breaks the ignore ofrestG4
library.The library is being loaded (altought it doesn't seem to cause any issue, just a warning).
This is because the library name contains
RestG4
, notrestG4
. This name is generated from the package name (restG4
) which is hardcoded intoTRestTools
. We could just useRestG4
instead ofrestG4
but I think we should instead use the case insensitive comparison so in the future if we can get all the package names automatically instead of hardcoding this will work without modifications.