Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing GitLab pipeline #310

Merged
merged 4 commits into from
Oct 6, 2022
Merged

Fixing GitLab pipeline #310

merged 4 commits into from
Oct 6, 2022

Conversation

jgalan
Copy link
Member

@jgalan jgalan commented Oct 4, 2022

jgalan Ok: 9

It requires to be merged to fix pipelines after updates to use the official materials repository.

It will be merged before tagging the official release v2.3.13.

@lobis
Copy link
Member

lobis commented Oct 4, 2022

I think we should wait to merge until the PR at restG4 is ready.

@jgalan
Copy link
Member Author

jgalan commented Oct 4, 2022

I think we should wait to merge until the PR at restG4 is ready.

Sure, we should wait, but when I asked for review it was ready ...

@jgalan jgalan mentioned this pull request Oct 4, 2022
@nkx111
Copy link
Member

nkx111 commented Oct 5, 2022

It lacks legibility to use sed to replace gdml file contents. Why not just put two files for validation?

@jgalan
Copy link
Member Author

jgalan commented Oct 5, 2022

It lacks legibility to use sed to replace gdml file contents. Why not just put two files for validation?

That was my original proposal, perhaps is cleaner because you just need 1-file and replace the old materials files on the fly.

Anyhow, it seems legibility is relative.

@lobis lobis merged commit 8066a6a into master Oct 6, 2022
@jgalan jgalan deleted the fixing_examples branch October 6, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants