Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding foreach to pull-submodules.py #320

Merged
merged 5 commits into from
Nov 9, 2022
Merged

Adding foreach to pull-submodules.py #320

merged 5 commits into from
Nov 9, 2022

Conversation

juanangp
Copy link
Member

@juanangp juanangp commented Oct 26, 2022

juanangp Ok: 48

Added git submodule foreach to pull-submodules.py script:

  • Avoids multiple request to github that might cause issues in unizar firewall
  • Speed up the checkout of the submodules

Note that the overall behaviour of pull-submodules.py has not been significatively changed, however note that git submodule foreach acts on all the submodules that have been initialized.

@juanangp juanangp requested review from jgalan and lobis October 26, 2022 11:54
@jgalan
Copy link
Member

jgalan commented Oct 26, 2022

I did a quick test of the pulling process, but it seems the output has been strongly affected
Screenshot 2022-10-26 at 18 13 11

@jgalan
Copy link
Member

jgalan commented Oct 26, 2022

This is how it looks in master

Screenshot 2022-10-26 at 18 15 19

@juanangp
Copy link
Member Author

juanangp commented Oct 26, 2022

This is how it looks in master

Screenshot 2022-10-26 at 18 15 19

Indeed, the output now is tricky because git submodule foreach gets the info for all the submodules at the same time.

I have changed it, now it gets the info at the different steps and it prints the hash after it is done, see below:
image

@jgalan jgalan requested a review from nkx111 November 2, 2022 11:40
@jgalan jgalan requested a review from a team November 9, 2022 16:38
@jgalan
Copy link
Member

jgalan commented Nov 9, 2022

This PR needs approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants