Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleaning and better string handling of TRestAnalysisTree and TRestEventProcess #339

Merged
merged 9 commits into from
Nov 30, 2022
Merged

cleaning and better string handling of TRestAnalysisTree and TRestEventProcess #339

merged 9 commits into from
Nov 30, 2022

Conversation

lobis
Copy link
Member

@lobis lobis commented Nov 29, 2022 •
edited by pull-request-badge bot

@lobis lobis mentioned this pull request Nov 29, 2022
Merged
@lobis lobis marked this pull request as ready for review November 29, 2022 13:44
@lobis lobis requested a review from a team November 29, 2022 20:15
@glorialuzon glorialuzon self-assigned this Nov 30, 2022
@glorialuzon
Copy link

I don't see any problem with the changes

@lobis lobis reopened this Nov 30, 2022
@lobis
Copy link
Member Author

lobis commented Nov 30, 2022

I don't see any problem with the changes

Can you approve?

glorialuzon
glorialuzon approved these changes Nov 30, 2022
View reviewed changes
Copy link

@glorialuzon glorialuzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem with changes

@lobis lobis merged commit a370e1e into master Nov 30, 2022
@lobis lobis deleted the glorialuzon-patch-1 branch November 30, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glorialuzon glorialuzon glorialuzon approved these changes

@cmargalejo cmargalejo cmargalejo approved these changes

@jgalan jgalan Awaiting requested review from jgalan

@juanangp juanangp Awaiting requested review from juanangp

Assignees

@glorialuzon glorialuzon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lobis @glorialuzon @cmargalejo