Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove repeated value for the speed of light #341

Merged
merged 4 commits into from
Nov 30, 2022
Merged

Conversation

Oscar-PL
Copy link
Member

@Oscar-PL Oscar-PL commented Nov 30, 2022

Oscar-PL Ok: 54

Speed of light was defined twice

Speed of light was defined twice
@jgalan
Copy link
Member

jgalan commented Nov 30, 2022

It seems for the moment only lightSpeed is used in the repository

jgalan@sultan2:~/rest-framework/source$ grep -rnw . -e "lightSpeed"
./framework/tools/inc/TRestPhysics.h:56:const double lightSpeed = 2.99792458E8;
./libraries/axion/src/TRestAxionField.cxx:97:    Double_t tm = REST_Physics::lightSpeed / REST_Physics::naturalElectron * 1.0e-9;  // GeV
./libraries/axion/src/TRestAxionField.cxx:114:    Double_t tm = REST_Physics::lightSpeed / REST_Physics::naturalElectron * 1.0e-9;  // gev
jgalan@sultan2:~/rest-framework/source$ grep -rnw . -e "speedLight"
./framework/tools/inc/TRestPhysics.h:41:const double speedLight = 2.99792458E8;
jgalan@sultan2:~/rest-framework/source$ 

Should we keep then lightSpeed?

@jgalan
Copy link
Member

jgalan commented Nov 30, 2022

Plz, approve #340 it is a fix to avoid undesired warnings.

@lobis lobis merged commit 621b4df into master Nov 30, 2022
@lobis lobis deleted the Oscar-PL-patch-2 branch November 30, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants