Updating validation.yml for using new readout validation #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgalan
commented
Jun 2, 2023
|
Just for my understanding, do we have to regenerate all the readouts to be compatible with the new code here rest-for-physics/detectorlib#86? |
lobis
approved these changes
Jun 2, 2023
Yes, I updated the readouts in the pipeline. We will have to re-generate other readouts. Once we have finished with the readout updates we will then fix a new release v2.4.0 which will require that we use the new readout versions. |
juanangp
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging this PR will fix pipeline at rest-for-physics/detectorlib#86