Updating hit positions scaling in Eve scene #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
juanangp
approved these changes
Jun 21, 2023
lobis
reviewed
Jun 21, 2023
lobis
reviewed
Jun 21, 2023
lobis
reviewed
Jun 21, 2023
lobis
reviewed
Jun 21, 2023
lobis
reviewed
Jun 21, 2023
lobis
reviewed
Jun 21, 2023
lobis
reviewed
Jun 21, 2023
lobis
reviewed
Jun 21, 2023
lobis
approved these changes
Jun 21, 2023
jgalan
commented
Jun 23, 2023
| @@ -68,8 +68,8 @@ class TRestBrowser { | |||
|
|
|||
| TRestEventViewer* fEventViewer = nullptr; //! | |||
|
|
|||
| void SetViewer(TRestEventViewer* eV, const Double_t& geomScale = 0.1); | |||
| void SetViewer(const TString& viewerName, const Double_t& geomScale = 0.1); | |||
| void SetViewer(TRestEventViewer* eV, Double_t geomScale = 0.1); | |||
There was a problem hiding this comment.
So finally it is better without const and reference?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the GEOM_SCALE define has been replaced by a data member at
TRestEventViewer::fGeomScale. In this way we can update the value of scaling dynamically. The default value is now back tofGeomScale=0.1. Recently it was updated in #440. However this has generated problems.Using the present PR and rest-for-physics/geant4lib#108, and the example
01.NLDBDI see the event properly placed now withwhile it is placed outside if I redefine
geomScaleto 1.0.This is only affecting visualisation
It would be interesting to find out when this is happening, so I added a warning message to encourage users feedback.