Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRestDataSetGainMap improvements and bug fixes #512

Merged
merged 13 commits into from
Apr 8, 2024
Merged

Conversation

AlvaroEzq
Copy link
Contributor

@AlvaroEzq AlvaroEzq commented Mar 15, 2024

AlvaroEzq Large: 526 Powered by Pull Request Badge

Bugs fixing:

  • TRestDataSetGainMap::Module::DrawSpectrum and DrawLinearFit didnt associate properly the subpad canvas to the corresponding spectrum/linearfit.
  • TRestDataSetGainMap::Module::DrawGainMap had fNumberOfSegmentsX and fNumberOfSegmentsY swapped.

Improvements:

  • Description for class attributes and cleaning header comments
  • Add cuts to apply to the input calibration TRestDataSet. Printing of the cut was implemented here because the TRestCut::PrintMetadata() does not show the cuts (maybe this should be addressed there instead...)
  • Possibility to exclude columns in TRestDatasetGainMap::CalibrateDataSet to exported TRestDataSet
  • Add whole module spectrum and calibration. For this, two private methods were added to avoid duplicated code.

@AlvaroEzq AlvaroEzq marked this pull request as ready for review April 3, 2024 15:34
@AlvaroEzq AlvaroEzq requested a review from nkx111 as a code owner April 3, 2024 15:34
@AlvaroEzq AlvaroEzq requested review from jgalan and lobis April 7, 2024 12:11
@AlvaroEzq AlvaroEzq merged commit 7a4a132 into master Apr 8, 2024
63 checks passed
@AlvaroEzq AlvaroEzq deleted the alvaroEzq_gmFix branch April 8, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants