Adding new TRestRawSignalRecoverChannelsProcess legacy process #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The pipeline at rest-for-physics/rawlib#92 is not passing. It complains about the The name of the branch at the rawlib is the same as the name of this branch, and I thought the rawlib would use this branch at the legacy module for validation. @juanangp Perhaps it is not the case and merging this PR will solve the pipeline problem at rawlib? |
I don't understand why the pipeline is failing but it can be a race condition. I can see that this branch is quite outdated wrt master, please update this one and rest-for-physics/rawlib#92 Note that we have changed the pipeline behaviour in between |
1 task
Anakintana
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also rest-for-physics/rawlib#92