Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stay in current window on split #257

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Conversation

volomas
Copy link
Contributor

@volomas volomas commented Nov 19, 2023

When you run request for this first time, focus is getting switched to the new windows with results buffer.
I've added simple flag that allows to configure this behavior: either stay in current windows (.http file) or change to results window (default)

Copy link
Member

@NTBBloodbath NTBBloodbath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you very much for this new addition!

Side note: maybe we should make this the default behavior afterwards?

@NTBBloodbath NTBBloodbath changed the title stay in current window on split feat: stay in current window on split Nov 28, 2023
@NTBBloodbath NTBBloodbath merged commit 734e696 into rest-nvim:main Nov 28, 2023
2 checks passed
@eeeXun
Copy link

eeeXun commented Nov 29, 2023

Side note: maybe we should make this the default behavior afterwards?

I agree!

@volomas
Copy link
Contributor Author

volomas commented Dec 1, 2023

Looks good to me, thank you very much for this new addition!

Side note: maybe we should make this the default behavior afterwards?

As for me, I would prefer to have it default.
Decided not to do so in this PR, because that's not what existing users might be used to.

wenjinnn pushed a commit to wenjinnn/rest.nvim that referenced this pull request Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants