Fix for ruby 3.0 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@donrestarone any chance this can get merged in? |
|
Thanks for the PR @robmathews and @AdnanTheExcellent for bringing it to my attention. Let me do some alpha testing on our end and get back to you on this. Ruby 3 is something we want to upgrade to but all our clients are on Ruby 2.6.6 |
|
@AdnanTheExcellent @robmathews this fix is now merged and available in the 3.3 release/tag: https://github.com/restarone/comfortable-mexican-sofa/releases/tag/3.3 thanks for your support! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When trying to load up the application in Rails 6.1 and Ruby 3.0, you get an error (sorry missing the error message here, but trust me). This fixes the error by adding the ** operator so that the passed in hash matches the named parameters.