remove rack-timeout and integrate slowpoke #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
blocks: #1419 please merge first |
| @@ -129,4 +129,5 @@ | |||
| # config.active_record.database_selector = { delay: 2.seconds } | |||
| # config.active_record.database_resolver = ActiveRecord::Middleware::DatabaseSelector::Resolver | |||
| # config.active_record.database_resolver_context = ActiveRecord::Middleware::DatabaseSelector::Resolver::Session | |||
| config.slowpoke.timeout = ENV['VIOLET_SERVICE_TIMEOUT'].to_i.nonzero? || 15 | |||
There was a problem hiding this comment.
please move this to an initializer so it works in all environments
|
Deployed review-app can be viewed at https://review-1454.violet-test.net |
|
@Pralish I did a spot of research on slowpoke, we should handle the following cases:
|
|
🧪 Test plan dokku apps:listlist apps ubuntu@ip-172-31-5-222:~$ dokku apps:list
=====> My Apps
review-1382
review-1433
review-1444
review-1446
review-1454
review-1455
violet-railsset a really short timeoutset timeout for this PR/APP (#1454) ubuntu@ip-172-31-5-222:~$ dokku config:set review-1454 VIOLET_SERVICE_TIMEOUT=1
-----> Setting config vars
VIOLET_SERVICE_TIMEOUT: 1
-----> Restarting app review-1454
-----> Releasing review-1454...
-----> Checking for predeploy task
No predeploy task found, skipping
-----> Checking for release task
-----> Executing release task from Procfile: bundle exec rails db:migrate
=====> Start of review-1454 release task (140ee7ce5) output
! No stripe.com API key was configured for environment production! this application will be
! unable to interact with stripe.com. You can set your API key with either the environment
! variable `STRIPE_SECRET_KEY` (recommended) or by setting `config.stripe.secret_key` in your
Migrating prashant tenant
Migrating root tenant
! environment file directly.
=====> End of review-1454 release task (140ee7ce5) output
-----> App Procfile file found
=====> Processing deployment checks
No CHECKS file found. Simple container checks will be performed.
For more efficient zero downtime deployments, create a CHECKS file. See https://dokku.com/docs/deployment/zero-downtime-deploys/ for examples
-----> Deploying review-1454 via the docker-local scheduler...
-----> Deploying web (count=1)
Attempting pre-flight checks (web.1)
Waiting for 10 seconds (web.1)
Default container check successful (web.1)
Scheduling old container shutdown in 60 seconds (web.1)
-----> Deploying release (count=0)
-----> Deploying worker (count=1)
Attempting pre-flight checks (worker.1)
Waiting for 10 seconds (worker.1)
Default container check successful (worker.1)
Scheduling old container shutdown in 60 seconds (worker.1)
-----> Running post-deploy
-----> Configuring review-1454.violet-test.net...(using built-in template)
-----> Creating https nginx.conf
Enabling HSTS
Reloading nginx
-----> Renaming containers
Found previous container(s) (785287facf83) named review-1454.web.1
Renaming container (785287facf83) review-1454.web.1 to review-1454.web.1.1678713046
Renaming container review-1454.web.1.upcoming-30795 (9fb34894c3c4) to review-1454.web.1
Found previous container(s) (a0c1cfd3a17f) named review-1454.worker.1
Renaming container (a0c1cfd3a17f) review-1454.worker.1 to review-1454.worker.1.1678713046
Renaming container review-1454.worker.1.upcoming-530 (11b4b48ebf56) to review-1454.worker.1
-----> Checking for postdeploy task
No postdeploy task found, skipping
-----> Updated schedule file
-----> Shutting down old containers in 60 seconds
=====> Application deployed:
http://review-1454.violet-test.net
https://review-1454.violet-test.nettail the logsdokku logs -t review-1454visit an expensive pagehttps://review-1454.violet-test.net/admin inspect log for thread timeout and restart2023-03-13T13:15:29.765040070Z app[web.1]: [c29b479a-452e-48a6-addf-14ce123ddc90] Rack::Timeout::RequestTimeoutError (Request waited 7ms, then ran for longer than 1000ms ):
2023-03-13T13:15:29.765044386Z app[web.1]: [c29b479a-452e-48a6-addf-14ce123ddc90]
2023-03-13T13:15:29.765048742Z app[web.1]: [c29b479a-452e-48a6-addf-14ce123ddc90] app/views/layouts/comfy/admin/cms/_body.html.haml:5
2023-03-13T13:15:29.765052648Z app[web.1]: [c29b479a-452e-48a6-addf-14ce123ddc90] app/views/layouts/comfy/admin/cms.html.haml:16
2023-03-13T13:15:29.766559263Z app[web.1]: - Gracefully stopping, waiting for requests to finishsee timeout on the browser + email notification
see that the server was terminated, and restarted to restore service
|
Isn't this being handled by our violet's exception notifier service? |
|
Deployed review-app can be viewed at https://review-1454.violet-test.net |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses:
#1434
#1419 (comment)